Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Show bonus xp end date #3025

Merged
merged 9 commits into from
Sep 20, 2024
Merged

feat: Show bonus xp end date #3025

merged 9 commits into from
Sep 20, 2024

Conversation

GabrielCWT
Copy link
Contributor

@GabrielCWT GabrielCWT commented Aug 21, 2024 •
edited by RichDom2185
Loading

This change adds a icon which gives a tooltip for when the bonus xp will start to decay.
Relevent Backend PR: source-academy/backend#1156

Closes #1964

Closes #355

@GabrielCWT GabrielCWT mentioned this pull request Aug 21, 2024
Merged
@coveralls
Copy link

coveralls commented Aug 21, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10953191698

Details

  • 1 of 5 (20.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.001%) to 31.449%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/commons/utils/DateHelper.ts 1 5 20.0%
Totals Coverage Status
Change from base Build 10841910509: -0.001%
Covered Lines: 4852
Relevant Lines: 14547
💛 - Coveralls

RichDom2185
RichDom2185 requested changes Aug 22, 2024
View reviewed changes
Copy link
Member

@RichDom2185 RichDom2185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor nits :)

src/styles/_academy.scss Outdated Show resolved Hide resolved
src/commons/utils/DateHelper.ts Outdated Show resolved Hide resolved
RichDom2185
RichDom2185 approved these changes Sep 20, 2024
View reviewed changes
Copy link
Member

@RichDom2185 RichDom2185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@RichDom2185 RichDom2185 enabled auto-merge (squash) September 20, 2024 04:30
@RichDom2185 RichDom2185 merged commit 23a408d into source-academy:master Sep 20, 2024
6 checks passed
@josh1248 josh1248 deleted the feat/show-bonus-xp-end-date branch October 27, 2024 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RichDom2185 RichDom2185 RichDom2185 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@GabrielCWT @coveralls @RichDom2185